Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Serf Reap event #2310

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Handle Serf Reap event #2310

merged 1 commit into from
Feb 14, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 13, 2017

This PR adds handling of the Serf member reap event to remove the peer
from Raft.

This PR adds handling of the Serf member reap event to remove the peer
from Raft.
@@ -88,6 +90,94 @@ func TestNomad_RemovePeer(t *testing.T) {
})
}

func TestNomad_ReapPeer(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] for lengthy tests I like a docstring describing what's being asserted.

@dadgar dadgar merged commit 0cc2d1a into master Feb 14, 2017
@dadgar dadgar deleted the f-serf-reap branch February 14, 2017 19:07
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants